Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spectrogram and inverse spectrogram #5779

Merged
merged 30 commits into from
Nov 22, 2024
Merged

spectrogram and inverse spectrogram #5779

merged 30 commits into from
Nov 22, 2024

Conversation

nihui
Copy link
Member

@nihui nihui commented Nov 15, 2024 •
edited
Loading

notes

  • only supports hann, hamming and all-one window
  • inverse spectrogram does not support length parameter
  • spectrogram always returns torch.view_as_real(out) as ncnn does not support complex typed mat yet
  • inverse spectrogram always accepts torch.view_as_complex(in) as ncnn does not support complex typed mat yet

@nihui nihui changed the title [WIP] spectrogram [WIP] spectrogram and inverse spectrogram Nov 18, 2024
This was referenced Nov 19, 2024
Open
Open
Closed
Closed
Closed
@tencent-adm
Copy link
Member

tencent-adm commented Nov 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the test label Nov 20, 2024
@nihui nihui changed the title [WIP] spectrogram and inverse spectrogram spectrogram and inverse spectrogram Nov 21, 2024
@github-actions github-actions bot added the doc label Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.49246% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.99%. Comparing base (6a466ef) to head (68b3816).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/layer/inversespectrogram.cpp 97.97% 2 Missing ⚠️
src/layer/spectrogram.cpp 99.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6a466ef) and HEAD (68b3816). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (6a466ef) HEAD (68b3816)
32 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #5779       +/-   ##
===========================================
- Coverage   95.00%   89.99%    -5.02%     
===========================================
  Files         795      267      -528     
  Lines      271196    79032   -192164     
===========================================
- Hits       257640    71122   -186518     
+ Misses      13556     7910     -5646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@nihui nihui merged commit 0734b65 into Tencent:master Nov 22, 2024
62 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core doc layer pnnx test tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nihui @tencent-adm @codecov-commenter